Add SharedKernel.Api test coverage and WebApi sample polish#343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/Vulthil.SharedKernel.Api.Tests(created by a prior PR) so every publicmember of
Vulthil.SharedKernel.Apiis exercised:BaseController,DependencyInjection's OpenAPI registration methods, the fullResultHttpExtensionsoverload set including the previously-untested
ToCreatedAtRouteHttpResult, and theinternal
GlobalExceptionHandler; broadenedEnrichProblemDetailsandMapEndpointsassertions.
samples/WebApi: add aSideEffectsControllerdemonstrating the keptBaseController+ToActionResultMVC path so the sample'sAddControllers()/MapControllers()registration is actually exercised, flow the endpoint-boundCancellationTokenthrough theCreate/GetById/GetAllhandlers, and let thecompiler infer
Create's minimal-API return type.samples/WebApi/WebApi.Tests.Verification
dotnet build Vulthil.SharedKernel.slnx— clean, 0 warnings / 0 errors.tests/Vulthil.SharedKernel.Api.Tests— 89/89 passing on net9.0 and net10.0.samples/WebApi/WebApi.Tests— 9/9 passing on net10.0 (the sample's only TFM),including a full round trip through real Postgres/RabbitMQ Testcontainers.
src/**/PublicAPI.*.txtchanged.Backport to v1.0: no — test and sample changes ship with the next release.